Repository navigation
Conversation
The OTel adapter deferred to the ambient OTel context for every live framework parent. An explicit parent different from the current span was therefore ignored in the exported tree. Use the live parent's OTel context when it differs from the ambient framework parent. Keep ambient OTel parenting otherwise, so user spans can still wrap framework spans and sub-agent runs. Cover explicit and non-current parents, raw OTel wrappers, and a mocked sub-agent run inside a tool's own OTel span.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you opened a span with
parent=set to a live span while a different span was current, itsparent_idwas right, but the OpenTelemetry trace still put it under the current span. Now the export uses the live parent you pass in. If you keep the currentai.telemetryparent, a raw OpenTelemetry span in between still shows up as the exported parent.