Repository navigation
Conversation
FileEvent accepts bytes, but its default JSON encoding treats them as UTF-8. Binary data can raise a serialization error, and ASCII bytes are written as raw text instead of the base64 used by FilePart. Use Pydantic's standard base64 encoder for JSON only. Keep strings unchanged and preserve bytes in Python-mode dumps. Add tests for binary, ASCII and empty bytes, string data, JSON round trips, and replayed file events.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaying a message with a binary file like a PNG could fail when you tried to dump its file event as JSON. We now encode bytes as base64, just like
FilePart, even when the bytes are valid UTF-8. Strings like URLs and Python-mode dumps are unchanged.