Skip to content

Fix NPE in parseChunk() - #745

Open
LonelyMidoriya wants to merge 1 commit into
integrationfrom
npe-chunk-parser
Open

Fix NPE in parseChunk()#745
LonelyMidoriya wants to merge 1 commit into
integrationfrom
npe-chunk-parser

Conversation

@LonelyMidoriya

@LonelyMidoriya LonelyMidoriya commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of PDF form artifacts when no artifact list is available.
    • Prevented validation failures caused by missing artifact data.

@LonelyMidoriya LonelyMidoriya self-assigned this Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5203dbd5-5f9d-4e3a-a903-31dadfc015a4

📥 Commits

Reviewing files that changed from the base of the PR and between 4dea032 and 60dbfde.

📒 Files selected for processing (1)
  • wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/ChunkParser.java

📝 Walkthrough

Walkthrough

Changes

Form artifact handling

Layer / File(s) Summary
Guard form artifact merging
wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/ChunkParser.java
Form XObject artifacts are merged only when xForm.getArtifacts() returns a non-null list.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: maximplusov, vladimir-burshnev

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: preventing a null-related failure in parseChunk().
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch npe-chunk-parser

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant