Skip to content

Fix NPE in getGlyphName() - #716

Open
LonelyMidoriya wants to merge 1 commit into
integrationfrom
open-type-font-program
Open

Fix NPE in getGlyphName()#716
LonelyMidoriya wants to merge 1 commit into
integrationfrom
open-type-font-program

Conversation

@LonelyMidoriya

@LonelyMidoriya LonelyMidoriya commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of glyph name requests when font data is not yet initialized, preventing unexpected errors.

@LonelyMidoriya LonelyMidoriya self-assigned this Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 307582e2-d03f-4af3-aaa3-6e4070548d32

📥 Commits

Reviewing files that changed from the base of the PR and between 2f315b8 and 9370f6c.

📒 Files selected for processing (1)
  • src/main/java/org/verapdf/pd/font/opentype/OpenTypeFontProgram.java

📝 Walkthrough

Walkthrough

getGlyphName(int) now returns null when the delegated OpenType font is unavailable. It preserves delegation when the font is initialized.

Changes

OpenType glyph lookup

Layer / File(s) Summary
Guard glyph-name delegation
src/main/java/org/verapdf/pd/font/opentype/OpenTypeFontProgram.java
getGlyphName(int) checks whether font is initialized before delegation and returns null otherwise.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: maximplusov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: preventing a null pointer exception in getGlyphName().
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch open-type-font-program

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant