Skip to content

Add DISC and DESCRIPTION to ASAtom - #710

Merged
MaximPlusov merged 2 commits into
integrationfrom
disc
Jul 27, 2026
Merged

Add DISC and DESCRIPTION to ASAtom#710
MaximPlusov merged 2 commits into
integrationfrom
disc

Conversation

@LonelyMidoriya

@LonelyMidoriya LonelyMidoriya commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added predefined support for the PDF names Description and Disc.
    • These names are now consistently recognized and returned as shared values when accessed.

@LonelyMidoriya LonelyMidoriya self-assigned this Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1391ce0e-1845-4998-822a-a02247671984

📥 Commits

Reviewing files that changed from the base of the PR and between a3320da and b8d22a2.

📒 Files selected for processing (1)
  • src/main/java/org/verapdf/as/ASAtom.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/org/verapdf/as/ASAtom.java

📝 Walkthrough

Walkthrough

ASAtom adds predefined shared constants for the PDF names "Description" and "Disc".

Changes

Predefined PDF name atoms

Layer / File(s) Summary
Add Description and Disc constants
src/main/java/org/verapdf/as/ASAtom.java
Adds public DESCRIPTION and DISC constants and registers both in PREDEFINED_PDF_NAMES.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: maximplusov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: two new ASAtom constants, DISC and DESCRIPTION, were added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch disc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LonelyMidoriya LonelyMidoriya changed the title Add DISC to ASAtom Add DISC and DESCRIPTION to ASAtom Jul 27, 2026
@MaximPlusov
MaximPlusov merged commit a0a7785 into integration Jul 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants