build: commit SilKitVersionMacros.h and regenerate with tool - #339
Open
MariusBgm wants to merge 6 commits into
Open
build: commit SilKitVersionMacros.h and regenerate with tool#339MariusBgm wants to merge 6 commits into
MariusBgm wants to merge 6 commits into
Conversation
Collaborator
Author
|
i think we should be able to pass the git hash as a define to the compilation |
Collaborator
Author
i think something like: would work in CI builds, without changing the current implementation. |
MariusBgm
marked this pull request as ready for review
July 6, 2026 07:19
Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
use silKitVersion.cmake to generate the C header Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
MariusBgm
force-pushed
the
dev/generate_version_tool
branch
from
September 1, 2026 15:16
4ebff27 to
f7895f1
Compare
… tool Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
…de the default Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit the version macros directly to the public include folders.
Add a small C++17 tool to regenerate the header with new version, git hash and optionally rotate the changelog.md if version number changed.
the tool does:
SilKit/cmake/SilKitVersion.cmakeSilKit/include/silkit/capi/SilKitVersionMacros.hwith git hash of last commitalso delete JenkinsFile and do not use SILKIT_BUILD_NUMBER in the versioning scheme