fix: verify OIDC ID tokens before mapping user info - #38
Open
onhate wants to merge 1 commit into
Open
Conversation
onhate
marked this pull request as ready for review
August 14, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
id_tokensignatures beforegetUserInfomaps profile claimsgetUserInfoandverifyIdTokenso algorithm, key, issuer, audience, and expiry checks cannot driftoidc.jwksFetchTimeoutMs, defaulting to 10 secondsWhy
Better Auth's authorization-code callback invokes the social provider's
getUserInfomethod directly. In v2.0.1, Telegram'sgetUserInfodecoded the returnedid_tokenwithdecodeJwtand mapped those unverified claims. The separateverifyIdTokencallback is used by Better Auth's direct ID-token sign-in routes, but not by the normal OAuth callback.This change makes the authorization-code path fail closed unless the token has a supported signature, a matching Telegram JWKS key, the expected issuer and audience, and a valid expiry.
Compatibility
RS256,ES256, andEdDSAjwksFetchTimeoutMsis additive; existing configurations receive the 10-second defaultValidation
npm run test -- src/oidc.test.ts— 106 passed, 4 skippednpm test— 347 passed, 4 skippednpm run type-checknpm run lintnpm run build