Skip to content

fix(ui): templates that could not deploy; delete dialog no longer claims data is deleted - #125

Merged
vazra merged 6 commits into
mainfrom
fix/template-deploy-bugs
Oct 11, 2026
Merged

vazra merged 6 commits into
mainfrom
fix/template-deploy-bugs

Conversation

@vazra

@vazra vazra commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Found by the E2E audit.

  • Multi-endpoint app templates failed in Quick test mode (mailpit, minio, docker-registry): every domain variable got the same sslip.io name, and the server refuses two endpoints with the same domain and path. The main domain keeps <slug>.<ip>.sslip.io; other domain variables get their own name (e.g. minio-console). The picker shows each auto domain.
  • 25 of 29 service templates could not deploy: adding a service copied its config but never declared the named volumes it uses, so the wizard said "Valid compose file" and docker compose up failed. Named volumes are now declared; a second copy gets its own volume (pgdata2) instead of sharing data.
  • gitea service template mounted /etc/timezone and /etc/localtime, which compose security checks refuse. Removed.
  • Delete App dialog said it deletes "all its data", but data volumes are kept (compose down without -v). The text now says what is removed, that volumes stay, and where to remove them (Docker page). Docs updated (archived-apps, CLI remove, apps-and-services).

Tests: per-template quick-test endpoint uniqueness (failed on exactly those 3), per-service-template volume declarations, click-through VisualEditor tests, delete dialog regression. Full vitest (590) passes.

Follow-up (not changed here): the mailpit template exposes SMTP (port 1025) as an HTTP endpoint through the proxy, which deploys now but likely cannot carry SMTP; it needs a template redesign.

vazra added 6 commits October 11, 2026 02:29
Its agent mounts the Docker socket, which deploy refuses for every app (host root access), so the template could not deploy since the compose security checks. The template matrix hid this by accepting a failed deploy for templates without an HTTP probe.
@vazra

vazra commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner Author

Template matrix shard 4 failed on Woodpecker CI: its agent mounts /var/run/docker.sock, which deploy refuses for every app since the compose security checks (host root). Before this branch the matrix accepted a failed deploy for templates with no HTTP probe, so the template looked fine. Removed the template in f3f32a1.

@vazra
vazra merged commit 3527326 into main Oct 11, 2026
12 checks passed
@vazra
vazra deleted the fix/template-deploy-bugs branch October 11, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant