Repository navigation
fix(ui): templates that could not deploy; delete dialog no longer claims data is deleted - #125
Merged
Merged
Conversation
Its agent mounts the Docker socket, which deploy refuses for every app (host root access), so the template could not deploy since the compose security checks. The template matrix hid this by accepting a failed deploy for templates without an HTTP probe.
Owner
Author
|
Template matrix shard 4 failed on Woodpecker CI: its agent mounts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the E2E audit.
<slug>.<ip>.sslip.io; other domain variables get their own name (e.g.minio-console). The picker shows each auto domain.docker compose upfailed. Named volumes are now declared; a second copy gets its own volume (pgdata2) instead of sharing data./etc/timezoneand/etc/localtime, which compose security checks refuse. Removed.compose downwithout-v). The text now says what is removed, that volumes stay, and where to remove them (Docker page). Docs updated (archived-apps, CLI remove, apps-and-services).Tests: per-template quick-test endpoint uniqueness (failed on exactly those 3), per-service-template volume declarations, click-through VisualEditor tests, delete dialog regression. Full vitest (590) passes.
Follow-up (not changed here): the mailpit template exposes SMTP (port 1025) as an HTTP endpoint through the proxy, which deploys now but likely cannot carry SMTP; it needs a template redesign.