feat(desktop): drag workspace files into composer - #786
Open
Blue-Berrys wants to merge 1 commit into
Open
Blue-Berrys wants to merge 1 commit into
Blue-Berrys wants to merge 1 commit into
Conversation
Owner
|
感谢时间,最近pr 有点多,我慢慢理! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Files shown in the bundled File Manager could not be dragged into the Composer, so users had to type a path or use the file picker instead.
Result
Regular, non-symlink file rows can now be dragged from the work panel into the Composer. A drop inserts one removable file chip using the workspace-relative path and leaves the source file in place. Direct and cross-WebContents delivery are deduplicated so one gesture creates one chip; directories remain navigation-only.
Closes #745
Validation
pnpm --filter @pi-desktop/shared buildpnpm --filter @pi-desktop/desktop typechecknode --experimental-strip-types --test test/composer-drag-drop.test.mjs(6 passed)node --test test/bundled-plugins.test.mjs(10 passed)pnpm lintpnpm docs:checkpnpm build:js