Skip to content

Add review skills and fix site findings - #9

Open
vartaxe wants to merge 1 commit into
mainfrom
copilot/review-and-skills-2026-10-17
Open

vartaxe wants to merge 1 commit into
mainfrom
copilot/review-and-skills-2026-10-17

Conversation

@vartaxe

@vartaxe vartaxe commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Install github-actions-hardening, docs-sync-audit, and web-design-reviewer.
  • Fix nested section spacing and light-theme accent contrast.
  • Restore the legacy /ConfigMgr-OSD/ redirect and add redirect/contrast validation.
  • Improve the docs checker to resolve skill-relative scripts, ignore code spans/fences, handle PowerShell environment reads, and decode URL-encoded links.

Validation

  • Site contrast checks: 4.5012:1 light and 7.5680:1 dark.
  • Local HTTP checks: canonical homepage and legacy redirect returned successfully.
  • Docs-drift regression test passed; git diff --check passed.

Install the selected Copilot skills, correct site spacing and accent contrast, restore the legacy redirect, and validate contrast and redirect behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Script-path normalization and query-bearing link handling incorrectly report valid resources as missing.

2 open issues
What changed in this PR

Adds reusable review skills and improves the static site’s presentation, legacy navigation, and validation.

Changes:

  • Adds workflow-security, documentation-audit, and visual-review skills.
  • Fixes section spacing and accent contrast, and restores the legacy redirect.
  • Adds redirect/contrast validation and documentation-checker improvements.
File Description
style.css Fixes nested spacing and light-theme contrast.
ConfigMgr-OSD/​index.html Restores the legacy redirect.
.github/​workflows/​validate-site.yml Validates redirect and label contrast.
.github/​skills/​web-design-reviewer/​SKILL.md Adds visual-review guidance.
.github/​skills/​web-design-reviewer/​references/​visual-checklist.md Adds visual and accessibility checks.
.github/​skills/​web-design-reviewer/​references/​framework-fixes.md Provides framework-specific fixes.
.github/​skills/​github-actions-hardening/​SKILL.md Adds workflow-security guidance.
.github/​skills/​github-actions-hardening/​references/​triggers-and-privilege.md Explains trigger trust boundaries.
.github/​skills/​github-actions-hardening/​references/​supply-chain.md Covers action and runner security.
.github/​skills/​github-actions-hardening/​references/​report-format.md Defines security report structure.
.github/​skills/​github-actions-hardening/​references/​permissions-and-tokens.md Documents token and secret controls.
.github/​skills/​github-actions-hardening/​references/​injection.md Explains injection prevention.
.github/​skills/​docs-sync-audit/​tests/​test_docs_drift.py Adds checker regression coverage.
.github/​skills/​docs-sync-audit/​SKILL.md Adds documentation-audit guidance.
.github/​skills/​docs-sync-audit/​scripts/​docs_drift.py Adds automated documentation checks.

Review effort: Balanced

f"documents `make {target}`, which is not a target in the Makefile.",
source="Makefile")
for whole, inner in CMD_SCRIPT.findall(line):
candidate = (inner or whole).lstrip("./")
# 2 and 3. links and backticked paths
for i, line in markdown_lines_without_code(text):
for target in MD_LINK.findall(line):
t = unquote(target.split("#")[0].strip())

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants