Skip to content

Add explicit banner dimensions #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vartaxe wants to merge 1 commit into from
Closed

Add explicit banner dimensions #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<p align="center">
<picture>
<source media="(max-width: 720px)" srcset="assets/banner-compact.svg?v=1.0.0" width="640">
<img src="assets/banner.svg?v=1.0.0" alt="ConfigMgr OSD Disk Partition Layout; Invoke-OSDDiskLayout.ps1; Windows PowerShell 5.1." width="1280">
<img src="assets/banner.svg?v=1.0.0" alt="ConfigMgr OSD Disk Partition Layout; Invoke-OSDDiskLayout.ps1; Windows PowerShell 5.1." width="1280" height="320">
</picture>
</p>

Expand Down
2 changes: 2 additions & 0 deletions Tests/Branding.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ Describe 'Project branding and Pages shell' {
It 'uses responsive banners with descriptive alternative text on both landing pages' {
$Readme | Should -Match '<source[^>]+banner-compact\.svg'
$Readme | Should -Match '<img[^>]+banner\.svg[^>]+alt="[^"]+"'
$Readme | Should -Match '<img[^>]+banner\.svg[^>]+width="1280"[^>]+height="320"'
$Index | Should -Match '<source[^>]+banner-compact\.svg'
$Index | Should -Match '<img[^>]+banner\.svg[^>]+alt="[^"]+"'
$Index | Should -Match '<img[^>]+banner\.svg[^>]+width="1280"[^>]+height="320"'
}

It 'keeps the destructive warning and unvalidated deployment boundary visible' {
Expand Down
2 changes: 1 addition & 1 deletion index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ title: ConfigMgr OSD Disk Partition Layout
<p align="center">
<picture>
<source media="(max-width: 720px)" srcset="assets/banner-compact.svg?v=1.0.0" width="640">
<img src="assets/banner.svg?v=1.0.0" alt="ConfigMgr OSD Disk Partition Layout; Invoke-OSDDiskLayout.ps1; Windows PowerShell 5.1." width="1280">
<img src="assets/banner.svg?v=1.0.0" alt="ConfigMgr OSD Disk Partition Layout; Invoke-OSDDiskLayout.ps1; Windows PowerShell 5.1." width="1280" height="320">
</picture>
</p>

Expand Down