Skip to content

Declare intrinsic banner dimensions - #2

Merged
vartaxe merged 1 commit into
mainfrom
fix-banner-dimensions
Oct 6, 2026
Merged

vartaxe merged 1 commit into
mainfrom
fix-banner-dimensions

Conversation

@vartaxe

@vartaxe vartaxe commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Summary

Add the banner SVG's intrinsic height="320" beside width="1280" on both landing pages to prevent layout shift, strengthen the existing branding regression to require both dimensions, and generate the exact-byte CHECKSUMS.txt manifest.

Safety impact

  • The fail-closed target-selection and pre-clean guards are unchanged; no runtime PowerShell implementation changed.
  • No support boundary, destructive behavior, or task-sequence requirement changed.
  • No sensitive deployment information is included.

Validation

  • powershell.exe -NoProfile -ExecutionPolicy Bypass -File .\build\Invoke-Validation.ps1 passes — 63 passed, 0 failed, 0 skipped, 0 not run.
  • Root and packaged script copies remain byte-identical — enforced by the passing validator.
  • New or changed logic has synthetic tests that do not modify hardware — the existing branding regression now requires width="1280" and height="320" on both landing pages.
  • Documentation reflects changed parameters, integration, or compatibility — no runtime documentation change is needed; only image presentation metadata changed.
  • Destructive behavior was tested only on disposable media, or the untested hardware boundary is stated explicitly — no destructive behavior changed or was exercised.

CHECKSUMS.txt contains 30 sorted uppercase SHA-256 entries and was independently verified against every maintained file except .git and the manifest itself.

Add intrinsic banner dimensions to prevent layout shift, enforce them in branding regression coverage, and record exact source checksums.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 20:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vartaxe
vartaxe merged commit 91ac7c9 into main Oct 6, 2026
2 checks passed
@vartaxe
vartaxe deleted the fix-banner-dimensions branch October 6, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants