Skip to content

fix: color only GOLDEN DUCK label #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
variablenix merged 1 commit into from
Aug 8, 2026
Merged

fix: color only GOLDEN DUCK label #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/duckhunt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,7 +1721,7 @@ func xpToNextLevel(xp int64) int64 {

func duckName(state *duckHuntState) string {
if state != nil && state.golden {
return ircColor(ircYellow, "the GOLDEN DUCK")
return "the " + ircColor(ircYellow, "GOLDEN DUCK")
}
if state != nil && state.flockRemaining > 1 {
return ircColor(ircCyan, "a duck in the flock")
Expand Down
11 changes: 11 additions & 0 deletions plugins/duckhunt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,17 @@ func TestDuckHuntAnnouncementKeepsDuckASCIICompact(t *testing.T) {
}
}

func TestDuckHuntGoldenDuckColorStartsAtLabel(t *testing.T) {
got := duckName(&duckHuntState{golden: true})
want := "the " + ircColor(ircYellow, "GOLDEN DUCK")
if got != want {
t.Fatalf("golden duck name = %q, want %q", got, want)
}
if strings.HasPrefix(got, ircYellow) {
t.Fatal("the article must not be yellow")
}
}

func TestDuckHuntSchedulesAfterActivityThreshold(t *testing.T) {
plugin := &DuckHunt{}
if err := plugin.Init(bot.PluginConfig{
Expand Down