Repository navigation
ci: commit the Angular example's lockfile - #106
Merged
Merged
Conversation
example/angular-app gitignored its package-lock.json, so CI resolved the example
fresh on every run. Since packages released on 14-15/10, npm 10 (Node 22) crashes
in that resolution ("Cannot read properties of null (reading 'edgesOut')"), which
failed the Angular example on every pull request. The lockfile, made with npm 11,
installs with npm 10 (ci and install) and the example builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Angular example gitignored its package-lock.json, so CI resolved it fresh each run.
With packages released on 14-15/10, npm 10 (Node 22, this repo CI) now crashes in that
resolution ("Cannot read properties of null (reading edgesOut)"): the Angular example
job fails on every pull request (#96, #102, #105), though develop did not change.
The lockfile is made with npm 11; with npm 10 it installs (ci and install) and the example
builds. The other three examples already commit theirs.