Skip to content

Fix Google weather script runtime failures - #5198

Open
davids5 wants to merge 1 commit into
valinet:masterfrom
davids5:weather_fix
Open

davids5 wants to merge 1 commit into
valinet:masterfrom
davids5:weather_fix

Conversation

@davids5

@davids5 davids5 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Recent changes in Google weather broke the last fragile fix.

  • Add robust weather icon lookup for changing image URLs
  • Guard missing location and invalid coordinates
  • Replace unbounded sunrise/sunset loop
  • Fix invalid C string escape

ep_weather_host.zip

- Add robust weather icon lookup for changing image URLs
- Guard missing location and invalid coordinates
- Replace unbounded sunrise/sunset loop
- Fix invalid C string escape
@Amrsatrio

Amrsatrio commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Works for me. LGTM.

Will merge later once I have lifted the commits from my fork to here.

@Number4000

Copy link
Copy Markdown

It's working for now with the "new" dll file. I hope it stands.

Thank you for the help!

@Number4000

Copy link
Copy Markdown

Now, following the change made about an hour ago, I no longer get weather details when clicking on the taskbar. Only a blank (empty) white square appears.

If I disable and re-enable the weather feature in ExplorerPatcher, the details come back.

A mystery...

@pyrates999

Copy link
Copy Markdown

No mystery if you're a programmer that understands how code works.

@Number4000

Copy link
Copy Markdown

No mystery if you're a programmer that understands how code works.

Good for you if you're a programmer. It's not the case for everyone. Please, have that in mind.

And as a programmer, we're all waiting for a fix that works. Untill then, have a good day.

@mattc0406

Copy link
Copy Markdown

I had to replace the DLL and change the icon pack from Google to Microsoft

@iG8R

iG8R commented Oct 5, 2026

Copy link
Copy Markdown

@mattc0406
Oh! With the Microsoft icon pack it started working.

@ShiftlessDrifter

Copy link
Copy Markdown

This worked with me today, including after a restart. Thank you!

@pyrates999

Copy link
Copy Markdown

You don't have to restart. Just disable weather. Replace the dll. Enable weather.

@markran

markran commented Oct 6, 2026

Copy link
Copy Markdown

Working for me too (once I changed icon pack to Microsoft). Thanks for fixing it!

@Wozmar

Wozmar commented Oct 7, 2026

Copy link
Copy Markdown

Thank you davids5 for the good file it works and everything is fine.

@pyrates999

pyrates999 commented Oct 7, 2026 •

Copy link
Copy Markdown

I would like to make a suggestion.

Can you include an option in EP to show the weather page as is?

This would allow people to get past the google thinks you're a bot, so that cookies can be set. It would also allow you as a developer to figure out if the code on the website changed, without having to use OBS Studio to capture the frame showing the reason why it would show no internet connection,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants