Skip to content

fix(logger): accept any Monolog handler as process manager log writer #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jremmurd wants to merge 1 commit into
base: pimcore12
Choose a base branch
from
+9 −3
Open

fix(logger): accept any Monolog handler as process manager log writer #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/Executor/Logger/AbstractLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
namespace Elements\Bundle\ProcessManagerBundle\Executor\Logger;

use Elements\Bundle\ProcessManagerBundle\Model\MonitoringItem;
use Monolog\Handler\StreamHandler;
use Pimcore\Bundle\ApplicationLoggerBundle\Handler\ApplicationLoggerDb;
use Monolog\Handler\HandlerInterface;

abstract class AbstractLogger
{
Expand Down Expand Up @@ -93,9 +92,16 @@ public function setConfig(array $config)
abstract public function getGridLoggerHtml(MonitoringItem $monitoringItem, array $actionData): string;

/**
* Returns the log writer which is registered on the monitoring item logger.
*
* Any Monolog handler is accepted here, because the return value is passed to
* ApplicationLogger::addWriter(), which handles every HandlerInterface implementation.
* Restricting this to StreamHandler would rule out handlers that do not write to a
* stream, for example the AsyncAws CloudWatch handler.
*
* @param array<mixed> $config
* @param MonitoringItem $monitoringItem
*
*/
abstract public function createStreamHandler(array $config, MonitoringItem $monitoringItem): StreamHandler | ApplicationLoggerDb | null;
abstract public function createStreamHandler(array $config, MonitoringItem $monitoringItem): ?HandlerInterface;
}