Make tracing solver controls configurable - #48
Draft
rogeriojorge wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
max_stepsandprogress_metercontrols toTracing.10_000_000_000Diffrax limit with a configurable default of1_000_000steps.NoProgressMeterby default while allowing callers to pass a Diffrax progress meter explicitly.rejected_stepsand eventconditionvalues.Scope
This PR contains only generic solver-control and constructor-default changes. It is independent of the VMEC magnetic-axis fix in #47 and does not change any model equations, coordinate handling, or loss classification.
FullOrbit_Borisis not a Diffrax solve and therefore does not usemax_steps; its iteration count remains determined by the requested output-time array.Validation
python -m pytest tests/test_dynamics.py -q: 14 passedwout_nfp3_final_scaled.nc,GuidingCenter, 10 particles,tmax=1e-4: completed in 1.68 s with trajectory shape(10, 21, 4)and 0% lossdiffeqsolvecall receivesself.max_steps