expr: replace onig with fancy-regex - #14329
Open
wtcpython wants to merge 1 commit into
Open
Conversation
sylvestre
reviewed
Aug 31, 2026
| if is_start_of_expression { | ||
| re_string.push(curr); | ||
| } else { | ||
| match curr { |
Contributor
There was a problem hiding this comment.
maybe move this into a new function?
wtcpython
force-pushed
the
expr-replace-onig
branch
from
August 31, 2026 12:19
d49f620 to
4bdf740
Compare
|
Binary size comparison: |
Contributor
https://docs.rs/fancy-regex/latest/fancy_regex/#features maybe we can disable some features |
wtcpython
force-pushed
the
expr-replace-onig
branch
3 times, most recently
from
August 31, 2026 13:02
ccb43d7 to
734f140
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
oech3
reviewed
Aug 31, 2026
Comment on lines
+390
to
+406
| && !matches!( | ||
| curr, | ||
| '1'..='9' | ||
| | '.' | ||
| | '*' | ||
| | '^' | ||
| | '$' | ||
| | '[' | ||
| | ']' | ||
| | '\\' | ||
| | 'w' | ||
| | 'W' | ||
| | 's' | ||
| | 'S' | ||
| | 'b' | ||
| | 'B' | ||
| ) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Replace the onig C-dependency in expr with the pure-Rust fancy-regex crate. This removes the onig_sys C library dependency while preserving full POSIX BRE, backreference, multibyte UTF-8, and C locale compatibility.
wtcpython
force-pushed
the
expr-replace-onig
branch
from
August 31, 2026 13:15
734f140 to
4c8805d
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the onig C-dependency in expr with the pure-Rust fancy-regex crate.
This removes the onig_sys C library dependency while preserving full POSIX BRE,
backreference, multibyte UTF-8, and C locale compatibility.
Closes #1145