stat: accept a hyphen-leading --format/--printf/-c value - #14323
Open
arbelonson-source wants to merge 1 commit into
Open
stat: accept a hyphen-leading --format/--printf/-c value#14323arbelonson-source wants to merge 1 commit into
arbelonson-source wants to merge 1 commit into
Conversation
--format (-c) and --printf's value was rejected as an unrecognized flag when given as its own argument (stat --format -%n f, not the attached -c-%n or --format=-%n): the Args were missing allow_hyphen_values, the same gap already fixed this session for several other options. GNU's own stat accepts any argument as the format string regardless of its first character. AI-assisted-by: Claude Opus 5, via Claude Code
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--format(-c) and--printf's value was rejected as anunrecognized flag when given as its own argument:
The attached forms (
-c-x,--format=-x) already worked; only theseparate-argument form broke -- the same
allow_hyphen_valuesgapalready fixed this session for several other options (
sort --parallel,nl's numeric options,ptx --gap-size/--width,join -t,csplit --suffix-format,paste -d,numfmt-d/--suffix/--padding).Testing
cargo test --features stat -p uu_stat/ fulltests/by-util/test_stat.rssuite: 44 passed, 0 failed.--format,--printf,-c) with the separate-argument hyphen-leading case.--format -x,--printf -x,-c -xagainst GNU stat 9.11 underLC_ALL=C.cargo clippy -p uu_stat --all-targets -- -D warningsandcargo fmt --check: clean.This PR was written with AI assistance (Claude Opus 5, via Claude Code). I've tested the changes but please review the code carefully.