Skip to content

Dev - #1

Open
ArnabChatterjee20k wants to merge 15 commits into
mainfrom
dev
Open

Dev#1
ArnabChatterjee20k wants to merge 15 commits into
mainfrom
dev

Conversation

@ArnabChatterjee20k

Copy link
Copy Markdown

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

Greptile Summary

The PR introduces an MQTT transport and packet-codec library with Swoole-backed server/client implementations, MQTT 3.1.1 and 5.0 encoders, property handling, documentation, tests, and containerized CI.

  • Correctly distinguishes receive timeouts, terminal socket errors, and peer closure in the client lifecycle.
  • Tracks active Swoole connections in shared memory across workers and independently of application callbacks.
  • Pins the GitHub Actions dependencies to immutable commit SHAs.
  • Adds MQTT packet encoding, parsing, property support, and unit and end-to-end coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/Mqtt/Client.php The revised receive paths correctly preserve connections on timeout and close them on EOF or terminal socket errors.
src/Mqtt/Adapter/Swoole.php The shared Swoole table and unconditional lifecycle handlers address idle, stale, and cross-worker connection tracking.
.github/workflows/tests.yml The test matrix builds and exercises PHP 8.1–8.3 images, with third-party actions pinned to full commit SHAs.
src/Mqtt/Packet.php Adds the common MQTT packet model and wire-format primitives used by both supported protocol versions.
src/Mqtt/Packet/V5.php Adds MQTT 5 packet encoders with property-block and enhanced-authentication support.
src/Mqtt/Properties.php Adds ordered MQTT 5 property-block encoding, parsing, lookup, and user-property access.

Reviews (4): Last reviewed commit: "track connections in a shared table, cle..." | Re-trigger Greptile

Comment thread src/Mqtt/Client.php
Comment thread src/Mqtt/Adapter/Swoole.php Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread src/Mqtt/Client.php
Comment thread src/Mqtt/Adapter/Swoole.php Outdated
Comment thread src/Mqtt/Adapter/Swoole.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant