Add cloudflare OAuth2 provider to migration allow-list - #224
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Greptile SummaryAdds Cloudflare to the OAuth2 provider allow-list so migrations retain its non-secret configuration.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The Cloudflare entry follows the established provider mapping and the added test verifies that only the transferable client ID is retained while secret fields remain excluded. Important Files Changed
Reviews (1): Last reviewed commit: "Add cloudflare OAuth2 provider to migrat..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
cloudflareto the OAuth2 provider allow-list so project migrations carry over the Cloudflare Dashboard OAuth2 configuration (client ID only — secrets are never copied, same as every other provider).Counterpart of appwrite/appwrite#13391, which introduces the Cloudflare OAuth2 provider. Mirrors the recent Resend addition in #223.
Test plan
testFromArrayCloudflarecovering key, enabled flag, settings, destination app ID, and that no secret fields are copiedtestFromArrayNeverCopiesSecretssweep now includes the new entrycomposer lintand./vendor/bin/phpunit tests/Migration/Unit/Resources/OAuth2ProviderTest.phppass (6 tests, 167 assertions)🤖 Generated with Claude Code