Skip to content

Add cloudflare OAuth2 provider to migration allow-list - #224

Merged
Meldiron merged 1 commit into
mainfrom
feat-cloudflare-oauth2-provider
Aug 27, 2026
Merged

Add cloudflare OAuth2 provider to migration allow-list#224
Meldiron merged 1 commit into
mainfrom
feat-cloudflare-oauth2-provider

Conversation

@Meldiron

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds cloudflare to the OAuth2 provider allow-list so project migrations carry over the Cloudflare Dashboard OAuth2 configuration (client ID only — secrets are never copied, same as every other provider).

Counterpart of appwrite/appwrite#13391, which introduces the Cloudflare OAuth2 provider. Mirrors the recent Resend addition in #223.

Test plan

  • testFromArrayCloudflare covering key, enabled flag, settings, destination app ID, and that no secret fields are copied
  • Existing testFromArrayNeverCopiesSecrets sweep now includes the new entry
  • composer lint and ./vendor/bin/phpunit tests/Migration/Unit/Resources/OAuth2ProviderTest.php pass (6 tests, 167 assertions)

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds Cloudflare to the OAuth2 provider allow-list so migrations retain its non-secret configuration.

  • Maps Cloudflare’s clientId to the destination application ID.
  • Adds unit coverage for enabled state, settings, destination mapping, configuration detection, and secret exclusion.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The Cloudflare entry follows the established provider mapping and the added test verifies that only the transferable client ID is retained while secret fields remain excluded.

Important Files Changed

Filename Overview
src/Migration/Resources/Auth/OAuth2/OAuth2Provider.php Adds Cloudflare using the existing generic client-ID mapping while preserving the secret-exclusion boundary.
tests/Migration/Unit/Resources/OAuth2ProviderTest.php Covers Cloudflare resource construction, destination application ID mapping, configured state, and omission of client secrets.

Reviews (1): Last reviewed commit: "Add cloudflare OAuth2 provider to migrat..." | Re-trigger Greptile

@Meldiron
Meldiron merged commit 3ea1ce6 into main Aug 27, 2026
4 checks passed
@Meldiron
Meldiron deleted the feat-cloudflare-oauth2-provider branch August 27, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant