Restrict Student Application Review Notifications to Profiles Accepting Students - #226
Open
betsyecastro wants to merge 1 commit into
Conversation
…ing students only
shukla-m
approved these changes
Sep 4, 2026
shukla-m
left a comment
shukla-m
left a comment
There was a problem hiding this comment.
@betsyecastro, Looks good! Tested by toggling Not accepted undergraduate students selection and using php artisan profiles:notify-about-students Fall 2027 command to check for email notifications.
- If a student had selected a faculty member on their application, and
- If the faculty member had checked
Not accepted undergraduate students, it didn't send them email notification, otherwise it sent them an email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profiles collection for student application notifications is now scoped to include only profiles that are not marked as "Not accepting students." This prevents profiles whose status has changed to "Not accepting students," but are still included in existing student applications that have been updated to include future semesters, from receiving email notifications.