Repository navigation
Stop rebuilding the menu bar menu on every block poll - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: trim the held-back list only when it has more than 10 entries.
Why: the per-package rows in the menu bar menu flicker when clicked. The poll reassigned
blockedevery 0.5 s, and since it's@Publishedthat rebuilt the menu each time, even with nothing new.How:
removeFirstonly when over 10, soblockedchanges only when a block arrives.Tested:
swiftc -typecheckonmacos/App.Untested: the menu itself; not run on a Mac with a held-back package.