Repository navigation
Re-land Windows Trust, logo and popup links - #90
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-lands #80, #81, #89 and #75, one commit each, in that order.
Why
#80, #81, #89 and #75 merged into stacked branches after their bases had landed, so main never got them.
How
Cherry-picked each PR's own commit from
windows/logoonto main, kept main's code where #68's reformat conflicted, thencargo fmt. #75 is the version stacked on #81's task dialog (what merged), not the standalone rebuild. Dependency changes redone withcargo add;Cargo.lockmatches the original.Tested
cargo build,cargo clippy --all-targets,cargo test,cargo fmt --check, with and withoutmachine-widecargo clippy --target x86_64-pc-windows-msvcontray.rsandpipe.rsin a scratch crate with main'swindowsfeaturesdist planUntested
build.rsembedding the manifest and icon) and the tray, popups and UAC prompt on Windows