fix chaotic-openapi: inproper serialization for single body requests - #1340
Open
alex-aparin wants to merge 5 commits into
Open
fix chaotic-openapi: inproper serialization for single body requests#1340alex-aparin wants to merge 5 commits into
alex-aparin wants to merge 5 commits into
Conversation
segoon
suggested changes
Sep 3, 2026
alex-aparin
marked this pull request as draft
September 4, 2026 07:19
…resolving at x-www-form-urlencoded fields
…order to reuse code and assertions
alex-aparin
marked this pull request as ready for review
September 4, 2026 21:09
Contributor
Author
|
Пару слов о новых коммитах - pr дополниткльно к заявленным 1,2 пунктам также чинит неожиданно найденные 3,4 пункты (они мешали рефакторингу и основному фиксу). В частности оказалось что $ref не обрабатывается корректно для form data + была поломана компиляция. Также при рефакторинге были учтены замечания к коду |
segoon
reviewed
Sep 5, 2026
… for form's fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialization for single body requests misses several things:
Upd: refactored tests with new openapi scheme revealed issues
3. Broken compilation because form fields treatment
4. Form fields work badly with $ref
Proposed pr fixes them also
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.