Skip to content

RockDB fix for MacOS #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apolukhin wants to merge 2 commits into from
Closed

RockDB fix for MacOS #1338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aaf49c
RockDB fix for MacOS
apolukhin Aug 31, 2026
c3cfc14
fix
apolukhin Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions rocks/src/storages/rocks/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#include <fmt/format.h>
#include <rocksdb/utilities/optimistic_transaction_db.h>
#include <rocksdb/utilities/transaction_db.h>

#include <rocksdb/utilities/checkpoint.h>
#include <rocksdb/version.h>

#include <userver/engine/async.hpp>
#include <userver/engine/task/current_task.hpp>
Expand All @@ -18,16 +18,22 @@ namespace storages::rocks {

namespace {

#if ROCKSDB_MAJOR > 9
using RawDbPointerType = std::unique_ptr<rocksdb::DB>;
#else
using RawDbPointerType = rocksdb::DB*;
#endif

std::shared_ptr<rocksdb::DB> OpenPlain(const std::string& db_path) {
rocksdb::Options options;
options.create_if_missing = true;

rocksdb::DB* db_raw{};
RawDbPointerType db_raw{};
const rocksdb::Status status = rocksdb::DB::Open(options, db_path, &db_raw);
if (!status.ok()) {
throw RequestFailedException("Create client", status.ToString());
}
return std::shared_ptr<rocksdb::DB>(db_raw);
return std::shared_ptr<rocksdb::DB>(std::move(db_raw));
}

} // namespace
Expand Down
Loading