Repository navigation
Several vaults per account (phase 3, 3.0.0-alpha.5) - #25
Merged
Merged
Conversation
An account had exactly one vault. It can now have more -- Home, Work, a project -- each with its own random key, kept wrapped to the account's public key. That is also how a vault's key will be handed to another member once vaults are shared (phase 4). - accounts.py: VaultFile (one vault: its files, key, name), and on Account: vault_ids, vault_file, create_vault, adopt_vault, rename_vault, delete_vault. The personal-vault methods delegate to it. - account_crypto.py: a vault's name sealed under the vault key, so the server lists vaults without learning their names. - account_sync.py: reconcile_vaults makes the list of vaults the same here and on the server, then every vault is synced on its own (AccountSync takes a vault id). A vault deleted on another device is KEPT here, marked and left out of the sync. Deleting a vault deletes it on the server first, so an unreachable server deletes nothing. - gui.py: a vault menu above the list (All vaults / Personal / ...), rows name their vault in the All view; _save writes only vaults that changed. - vaults_ui.py (new): the Vaults window -- new, rename, delete (asks for the master password), put back. - dialogs.py: a vault picker in Add an entry; import says which vault; the archive-purge setting applies to every vault; export follows the menu. sync_ui.py: the archive and the conflict window follow the vault. - Needs SecretSpace Server 2.0.0-alpha.2 for more than the personal vault; an older 2.0 server keeps syncing the personal one and the app says so. tests/test_account_vaults.py: 57 tests; 10 of 10 deliberately broken versions were caught. tests/sync_server/passman_server.py is the server 2.0.0-alpha.2 copy. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ojnyVg7ccsR3pZ64s7aRH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3 of SecretSpace 3: several vaults in one account (a test version). Needs the server PRs "Several vaults per account (API v2, 2.0.0-alpha.2)" for syncing more than the Personal vault.
For the user
How
Checked
tests/test_account_vaults.py: 57 new tests, real HTTP against the server copy. 10 of 10 deliberately broken versions were caught.flows_vaults.py56/56 (it fails when the Add dialog ignores the picker, and when a sync deletes a local vault),flows_accounts.py42/42,flows_sync_accounts.py22/22.Not in this PR
Moving an entry from one vault to another; sharing; the change log (both phase 4).
The tests and the Lab flow were written by Sonnet 5.5 subagents and reviewed.
🤖 Generated with Claude Code
https://claude.ai/code/session_011ojnyVg7ccsR3pZ64s7aRH