Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing a GFM table in rich mode currently leaves the header and delimiter in a paragraph. The paragraph serializer then escapes the delimiter's first dash to preserve the paragraph model, so the saved Markdown no longer parses as a table.
This change recognizes a complete typed table after the first full-width body row is finished. It reuses the existing Markdown parser and row splitter, converts the paragraph to the parsed table model, and keeps the caret at the end of the last typed cell. Waiting for the body row avoids converting while the user is still typing the delimiter, and the raw row-width check prevents short rows from triggering the shortcut early.
The command tests cover conversion, caret placement, incomplete input, delimiter-only input, header-plus-delimiter input, and width mismatch. The browser regression types the sequence reported in usememos/memos#6480 and verifies that the saved Markdown is a valid table without an escaped delimiter.
Verified with:
npm test(10,125 passed; 59 todo)npm run typecheckgit diff --check