Repository navigation
fix(reader): improve search and rendering and restore Markdown contents - #63
Lanlan13-14 wants to merge 1 commit into
Conversation
|
hey @Lanlan13-14 Thanks for this, A heads-up before anything else: I've been working on some of the same changes that isn't pushed yet. It covers search and the table of contents in rendered Markdown, serving the bundled fonts to the renderer, a WebView held for the reader's lifetime, and moving the editor preview and export onto the same renderer. That overlaps with a good part of this PR, and the two conflict in most of the Kotlin files. So I'd like to leave this open for now rather than merge or close it. Once that stack is in One thing to know for later: everything under No need to rebase or change anything in the meantime. |
|
Thanks for the detailed update and for taking the time to review this! That makes sense — I’ll leave the PR as it is while your changes land. Thanks also for clarifying the renderer vendoring workflow. One other thing I’d love to see improved is the editing experience for large Markdown files. Editing them is currently very laggy, especially when typing in long paragraphs. Would you consider looking into editor performance as well? It would make a big difference when working with larger documents. |
|
Sure, will take a look at it but after the planned changes land so it will take some time. |
Changes
Tests
All completed checks passed:
CI results