Return errors instead of log.Fatalf in lifecycle/cli_adaptor.go - #12
Open
magic-peach wants to merge 1 commit into
Open
Return errors instead of log.Fatalf in lifecycle/cli_adaptor.go#12magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
log.Fatalf calls os.Exit(1) directly, which kills the whole harness process on a single trial's command failure instead of letting the orchestrator record the trial as failed and move on. Each CLI* helper here already returns (StageResult, error) as part of its signature, so no caller changes were needed: the fatal calls are replaced with returning the underlying error wrapped with fmt.Errorf, matching the error-wrapping style already used elsewhere in the codebase (e.g. internal/runtime/storage/adapter.go's getOrPullImage). log.Printf calls that were already non-fatal (e.g. best-effort stop/ cleanup logging) are left as-is. Updates urunc-dev#10 Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #10 (a single failed trial currently kills the entire benchmark harness process via log.Fatalf). This PR covers just
internal/runtime/lifecycle/cli_adaptor.go: replaces its 7log.Fatalfcalls with wrapped errors, since every affected method already returns(StageResult, error)-- no signature/caller changes needed.Issues Resolved
Updates #10 (one of four small PRs against this issue, one per file -- not closing it alone)
Testing
go build,go vet,gofmt -l,go test ./...all clean.