Skip to content

Dynamically watch for changes on the numeric column #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miexil merged 2 commits into from
Aug 12, 2026
Merged

Dynamically watch for changes on the numeric column #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46598f
Updated - dynamically watch for changes on the numeric column
Miexil Aug 12, 2026
626f445
Use ember get instead of defineProperty for Text and Numeric cells
Miexil Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion addon/components/hyper-table-v2/cell-renderers/numeric.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { get } from '@ember/object';
import Component from '@glimmer/component';

import TableHandler from '@upfluence/hypertable/core/handler';
Expand All @@ -12,6 +13,6 @@ interface HyperTableV2RenderersNumericArgs {

export default class HyperTableV2CellRenderersNumeric extends Component<HyperTableV2RenderersNumericArgs> {
get value() {
return this.args.row[this.args.column.definition.key];
return get(this.args.row, this.args.column.definition.key);
}
}
14 changes: 3 additions & 11 deletions addon/components/hyper-table-v2/cell-renderers/text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { computed, defineProperty } from '@ember/object';
import { get } from '@ember/object';
import Component from '@glimmer/component';

import TableHandler from '@upfluence/hypertable/core/handler';
Expand All @@ -12,15 +12,7 @@ interface HyperTableV2CellRenderersTextArgs {
}

export default class HyperTableV2CellRenderersText extends Component<HyperTableV2CellRenderersTextArgs> {
constructor(owner: unknown, args: HyperTableV2CellRenderersTextArgs) {
super(owner, args);

defineProperty(
this,
'value',
computed(`args.row.${args.column.definition.key}`, function () {
return this.args.row[this.args.column.definition.key];
})
);
get value() {
return get(this.args.row, this.args.column.definition.key);
}
}
Loading