fix: Various bugfixes - #335
Merged
Merged
Conversation
The waiting to be merged list reads the new open actions endpoint and shows one row per pull request, led by the worst result of the pipelines feeding it. Home shows the 5 most recent, the dashboard and the reports page page through every one matching their filter.
A page the reader asks for only becomes the current one once it arrived. When it fails, the pager stays on the rows shown and says the page could not be loaded, until the reader asks for a page again or changes the filter; a background refresh no longer clears it. A refresh that lands while a page is pending loads that page too. Pull requests whose link is not http(s) are now listed as plain text instead of being dropped, so the list agrees with the count.
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
The label keys and values were fetched for a time window frozen when the page loaded, and only fetched again when the date range moved. A page left open never offered a label first reported after it loaded. The window is now read at request time, and the lists follow the live refresh like the reports and charts they filter. Values of label rows restored from the URL or the saved filter are loaded too, and so are those of selected rows after a range change. A response superseded by a newer refresh is dropped instead of overwriting a newer list. A failed refresh keeps the lists it had while the range is unchanged, and empties them after a range change. Signed-off-by: Olivier Vernin <olivier@vernin.me>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdds a reusable, paginated pull-request list to dashboard, reports, and waiting-queue views. Updates SCM label refresh handling and shared filter request construction. Adds tests for pull-request rendering, pagination, refresh edge cases, label refresh behavior, and request-body mapping. Removes the reports page’s aggregate pull-request list. ChangesPull-request lists
SCM filter refresh
Activity chart template comments
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant DashboardView
participant PullRequestList
participant ActionsAPI
DashboardView->>PullRequestList: pass filter and list options
PullRequestList->>ActionsAPI: request filtered, paginated actions
ActionsAPI->>PullRequestList: return actions and count
PullRequestList->>DashboardView: render pull-request rows and pagination
Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established by the available evidence. The API response contract remains unverified, but that uncertainty alone does not prevent merging. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected flows retain existing credential handling and safe-link controls. No introduced security regression was established, but server-side response and access rules, and parts of the before-and-after comparison, remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 3 | ❌ 1 | ❓ 1❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 53.85% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 6 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
/
Additional Information
Tradeoff
Potential improvement
Summary by CodeRabbit