Skip to content

ci: close pro issues on release with different message than oss - #659

Merged
Brentlok merged 1 commit into
mainfrom
ci/close-on-release
Sep 2, 2026
Merged

ci: close pro issues on release with different message than oss#659
Brentlok merged 1 commit into
mainfrom
ci/close-on-release

Conversation

@Brentlok

@Brentlok Brentlok commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Release-related issue comments now link to the appropriate changelog for pro releases.
    • Standard release issues continue to reference the relevant release tag and GitHub release page.
    • Existing labeling, commenting, and issue-closing behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 8f45c58d-2f59-4c32-b146-e53e136ad745

📥 Commits

Reviewing files that changed from the base of the PR and between af5f834 and 2e61e7f.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now detects the uniwind-pro label when it processes pending release issues. It uses the pro changelog URL for labeled issues and retains the existing release message for other issues.

Changes

Release issue comment routing

Layer / File(s) Summary
Select release issue comments
.github/workflows/release.yaml
The workflow reads the uniwind-pro label and selects the matching comment message. Label removal, commenting, issue closing, and failure warnings remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2e61e

This is a localized release-workflow message change, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: the release workflow closes pro issues with a different message from OSS issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/close-on-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the release workflow to distinguish Pro issues from OSS issues when closing items marked pending-release.

  • Includes issue labels in the GitHub CLI query and detects the uniwind-pro label.
  • Directs Pro users to the Pro changelog while retaining the tagged GitHub release message for OSS issues.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The label query emits a paired issue number and boolean for each result, and the workflow uses that classification to select the intended static message without changing the existing edit, comment, and close sequence.

Important Files Changed

Filename Overview
.github/workflows/release.yaml The workflow now selects a release comment based on the issue’s Pro label; the jq output and shell field handling remain consistent for the expected issue data.

Reviews (1): Last reviewed commit: "ci: close pro issues on release with dif..." | Re-trigger Greptile

@Brentlok
Brentlok merged commit 9186a34 into main Sep 2, 2026
3 checks passed
@Brentlok
Brentlok deleted the ci/close-on-release branch September 2, 2026 08:35
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🚀 This pull request is included in v1.12.0. See Release v1.12.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant