Repository navigation
fix: enforce BFS max_pages across each level - #2341
Closed
nightcityblade wants to merge 1 commit into
Closed
nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for picking this up so quickly, @nightcityblade, and for adding a test! #2339 fixed the same issue and is now merged. It includes your Thanks again for your effort, and we'd be happy to see more PRs from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2338
Count URLs already queued for the next BFS level against the remaining max_pages budget so sibling parent pages cannot oversubscribe it.
List of files changed and why
How Has This Been Tested?
Checklist: