12714 enable locally fair flag - #97
Open
ashmanda-cs wants to merge 5 commits into
Open
ashmanda-cs wants to merge 5 commits into
ashmanda-cs wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The added workflow flag matches an existing feature flag key and is correctly wired into the existing multi-line Maven invocation without introducing script or YAML issues.
Pull request overview
This PR enables the dataverse.feature.allow-locally-fair-data feature flag in the GitHub Actions workflows that start the Dataverse stack for JSF and container integration tests, ensuring those CI runs execute with Locally FAIR functionality turned on.
Changes:
- Pass
-Ddataverse.feature.allow-locally-fair-data=trueto the Mavendocker:startinvocation in JSF workflow runs. - Pass
-Ddataverse.feature.allow-locally-fair-data=trueto the Mavendocker:startinvocation in container integration workflow runs.
File summaries
| File | Description |
|---|---|
| .github/workflows/dataverse_jsf_tests.yml | Enables the Locally FAIR feature flag when starting the test stack for JSF tests. |
| .github/workflows/container_integration_tests.yml | Enables the Locally FAIR feature flag when starting the test stack for container integration tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Coverage Report for CI Build 133Coverage remained the same at 25.412%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: