Skip to content

fix: add missing tslib runtime dependency - #265

Merged
JounQin merged 1 commit into
un-ts:mainfrom
Neat-eu:fix/tslib-missing-dependency
Sep 20, 2026
Merged

fix: add missing tslib runtime dependency#265
JounQin merged 1 commit into
un-ts:mainfrom
Neat-eu:fix/tslib-missing-dependency

Conversation

@utix

@utix utix commented Sep 20, 2026 •
edited by JounQin
Loading

Copy link
Copy Markdown
Contributor

Fix #266

Summary

  • tsconfig.json (via @1stg/tsconfig) sets importHelpers: true, so compiled output
    emits real import { ... } from "tslib" statements (e.g. lib/gitlab.js)
  • tslib was never added to dependencies, so npx changesets-gitlab@0.16.0 comment
    fails at runtime with ERR_MODULE_NOT_FOUND: Cannot find package 'tslib'
  • 0.15.1 didn't hit this; it's a regression introduced by 0.16.0's build output

Test plan

  • yarn build succeeds
  • node -e "import('./lib/gitlab.js')" succeeds (previously failed with the exact
    reported error)
  • yarn test - 46/46 passing
  • yarn lint:tsc clean
  • Changeset added (patch)

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an issue that could prevent compiled output from running correctly through npx.
  • Chores
    • Added the required runtime support dependency to ensure consistent execution.

@utix
fix: add missing tslib runtime dependency
22cbcef 
Compiled output imports tslib at runtime (importHelpers tsconfig
option) but it was never declared as a dependency, causing
ERR_MODULE_NOT_FOUND when installed via npx.
@changeset-bot

changeset-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 22cbcef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a01549a6-7a6c-45c8-a5f4-021f8f8f79b3

📥 Commits

Reviewing files that changed from the base of the PR and between fd039fe and 22cbcef.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .changeset/fix-tslib-missing-dependency.md
  • package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

📝 Walkthrough

Walkthrough

The package now declares tslib version ^2.8.1 as a runtime dependency. A patch changeset documents the missing dependency and its npx failure mode.

Changes

Runtime dependency declaration

Layer / File(s) Summary
Dependency and release metadata
package.json, .changeset/fix-tslib-missing-dependency.md		 package.json adds tslib to runtime dependencies. The changeset records the patch release and the associated npx module error.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: jounqin

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the missing tslib runtime dependency.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Sep 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codacy-production

codacy-production Bot commented Sep 20, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@utix utix mentioned this pull request Sep 20, 2026
Closed
@pkg-pr-new

pkg-pr-new Bot commented Sep 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/changesets-gitlab@265

commit: 22cbcef

@JounQin
JounQin merged commit 4497447 into un-ts:main Sep 20, 2026
12 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JounQin JounQin JounQin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0.16.0: ERR_MODULE_NOT_FOUND for tslib at runtime, missing from dependencies

2 participants

@utix @JounQin