Skip to content

Reduce number of plasma profile elements from 501 to 101#4416

Open
timothy-nunn wants to merge 1 commit into
mainfrom
4301-make-full-profile-output-in-mfile-optional
Open

Reduce number of plasma profile elements from 501 to 101#4416
timothy-nunn wants to merge 1 commit into
mainfrom
4301-make-full-profile-output-in-mfile-optional

Conversation

@timothy-nunn

@timothy-nunn timothy-nunn commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@timothy-nunn
timothy-nunn requested a review from a team as a code owner July 6, 2026 14:52
@timothy-nunn timothy-nunn linked an issue Jul 6, 2026 that may be closed by this pull request
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (8ff9577) to head (f64a035).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/main.py 33.33% 2 Missing ⚠️
process/models/physics/physics.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4416      +/-   ##
==========================================
+ Coverage   48.82%   48.84%   +0.01%     
==========================================
  Files         151      151              
  Lines       29409    29413       +4     
==========================================
+ Hits        14360    14366       +6     
+ Misses      15049    15047       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe

Copy link
Copy Markdown
Collaborator

@timothy-nunn May as well change the value of n_plasma_profile_elements down to 100 here also

@timothy-nunn

Copy link
Copy Markdown
Collaborator Author

@timothy-nunn May as well change the value of n_plasma_profile_elements down to 100 here also

I would probably opt to do that in another PR since it will cause massive regression failures

@je-cook

je-cook commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

I dont see the need for this option being exposed on the main process cli, especially as the MFILE is explicitly the machine readable version. I prefer the option of reducing the number of points recorded. This is surely only talking about 121kB (31entries*500points*8bytes) / 1024 to 12kB assuming 7 char per entry?

@timothy-nunn
timothy-nunn force-pushed the 4301-make-full-profile-output-in-mfile-optional branch from f64a035 to 6aa7141 Compare July 24, 2026 08:04
@timothy-nunn timothy-nunn changed the title Allow detailed physics profile output to be switched off Reduce number of plasma profile elements from 501 to 101 Jul 24, 2026
@timothy-nunn
timothy-nunn requested a review from a team July 24, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make full profile output in MFILE optional

4 participants