Skip to content

[BDC-1248] Fix DOI discovery - #311

Merged
SpencerAxelrod merged 3 commits into
masterfrom
fix/BDC-1248
Aug 12, 2026
Merged

[BDC-1248] Fix DOI discovery#311
SpencerAxelrod merged 3 commits into
masterfrom
fix/BDC-1248

Conversation

@SpencerAxelrod

@SpencerAxelrod SpencerAxelrod commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/BDC-1248

New Features

Breaking Changes

Bug Fixes

  • get_alternate_id_to_guid_mapping() relied on the export helper's default 500 record limit, so commons with more records lost mappings for records over the limit. Now passes an explicit DOI_DISCOVERY_METADATA_EXPORT_LIMIT = 10_000.
  • dbgapDOI.get_metadata_for_ids() raised on the first record with an invalid ReleaseDate (e.g. None), preventing all other valid records in the same call from being processed. Now isolates each accession's metadata construction so failures are skipped individually and logged.
  • add missing os import

Improvements

  • Invalid records are logged and skipped without blocking valid records in the same batch.
  • Added regression test coverage
  • Updated docs/howto/discoveryMetadataTools.md

Dependency updates

Deployment changes

@github-actions

Copy link
Copy Markdown

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@github-actions

Copy link
Copy Markdown

Integration Tests

Test summary after running integration tests

filepath passed failed skipped SUBTOTAL
tests/test_dbgap.py 4 0 1 5
tests/test_ras_passport.py 0 0 2 2
tests/test_data_upload.py 8 0 1 9
tests/test_graph_submit_and_query.py 12 1 1 14
tests/test_presigned_url.py 7 0 0 7
tests/test_centralized_auth.py 5 0 0 5
tests/test_google_data_access.py 1 0 0 1
tests/test_audit_service.py 1 0 0 1
tests/test_drs_endpoint.py 2 0 0 2
tests/test_gen3_sdk.py 1 0 0 1
TOTAL 41 1 5 47

Test summary after rerunning failed integration tests

filepath passed SUBTOTAL
tests/test_graph_submit_and_query.py 1 1
TOTAL 1 1

Please find the detailed integration test report here

Please find the detailed integration test report after rerunning failed tests here

Please find the Github Action logs here

@github-actions

Copy link
Copy Markdown

Integration Tests

Test summary after running integration tests

filepath passed failed skipped SUBTOTAL
tests/test_dbgap.py 4 0 1 5
tests/test_ras_passport.py 0 0 2 2
tests/test_data_upload.py 8 0 1 9
tests/test_graph_submit_and_query.py 12 1 1 14
tests/test_presigned_url.py 7 0 0 7
tests/test_centralized_auth.py 5 0 0 5
tests/test_google_data_access.py 1 0 0 1
tests/test_audit_service.py 1 0 0 1
tests/test_drs_endpoint.py 2 0 0 2
tests/test_gen3_sdk.py 1 0 0 1
TOTAL 41 1 5 47

Test summary after rerunning failed integration tests

filepath passed SUBTOTAL
tests/test_graph_submit_and_query.py 1 1
TOTAL 1 1

Please find the detailed integration test report here

Please find the detailed integration test report after rerunning failed tests here

Please find the Github Action logs here

@SpencerAxelrod
SpencerAxelrod merged commit 0e90a05 into master Aug 12, 2026
18 checks passed
@SpencerAxelrod
SpencerAxelrod deleted the fix/BDC-1248 branch August 12, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants