Chore/merge gsoc - #309
Conversation
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
…github.com/Dhiren-Mhatre/gen3sdk-python into feat/multiple-download-performance-testing
…formance-testing Feat/multiple download performance testing
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Integration TestsTest summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
Integration TestsTest summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
Integration TestsTest summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
| ) as session: | ||
| while True: | ||
| try: | ||
| # Check if queue is empty with timeout |
There was a problem hiding this comment.
Is there supposed to be a timeout around here? I see a commit called "removed timeout" in the history. But also, should we not send a better completion signal here (instead of a timeout)?
There was a problem hiding this comment.
like have _guid_producer put one None (input_queue.put(None)) per worker after the GUIDs. Have this loop break when it reads one.
|
|
||
| while completed_count < len(guids): | ||
| try: | ||
| batch_results = output_queue.get() |
There was a problem hiding this comment.
if every worker dies before producing all len(guids) results, this blocks forever instead of erroring out and the except Empty right below never gets hit
New Features
Dependency updates
Updated fastavro from 1.8.4 to 1.11.1
Updated pypfb to include extras: pypfb = {extras = ["gen3"], version = "^0.5.33"}
Updated importlib-metadata from 8.5.0 to 4.13.0