Repository navigation
fix(stovepipe): initialize queue state within ingest - #972
Merged
Merged
Conversation
## Why? Hosts should not need to construct an internal queue transition controller or register queue state before calling Ingest. A first ingest with explicit enablement currently fails without that registration. ## What? NewIngestController constructs its transition controller from its existing dependencies. Ingest idempotently initializes the queue and its history and summary before applying an optional enablement decision, including when adopting an existing empty queue row. Existing enablement and pipeline fields are preserved. Remove startup registration from the reference service. Construction performs no storage I/O; GetQueueStatus remains read-only and returns NOT_FOUND before the first ingest initializes state. ## Test Plan - make fmt, make lint, make check-tidy, make check-gazelle - ./tool/bazel test //stovepipe/... //service/stovepipe/server/... --test_tag_filters=-integration --build_tests_only --test_output=errors - Queue-status, ingest, list, ping, and issue-tracking DLQ end-to-end scenarios pass: `./tool/bazel test //test/e2e/stovepipe:go_default_test --test_output=errors '--test_arg=-testify.m=Test(Ingest|QueueStatus|IssueTracking_DLQ|List|Ping)'`. - The full end-to-end suite times out waiting for issue-tracking finalization. The isolated `TestIssueTracking_FinalizesAfterAnalysis` also times out on unchanged main at 0edea98 with a 120-second Bazel limit. - Regression coverage for new and existing empty queues, initial explicit decisions, idempotent retries, preservation of pipeline fields, and recovery from partial history/summary writes.
mnoah1
marked this pull request as ready for review
October 28, 2026 14:53
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 28, 2026 14:53
mnoah1
enabled auto-merge
October 28, 2026 14:53
prathshenoy
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Hosts should not need to construct an internal queue transition controller or register queue state before calling Ingest. A first ingest with explicit enablement currently fails without that registration.
What?
NewIngestController constructs its transition controller from its existing dependencies. Ingest idempotently initializes the queue and its history and summary before applying an optional enablement decision, including when adopting an existing empty queue row. Existing enablement and pipeline fields are preserved.
Remove startup registration from the reference service. Construction performs no storage I/O; GetQueueStatus remains read-only and returns NOT_FOUND before the first ingest initializes state.
Test Plan
./tool/bazel test //test/e2e/stovepipe:go_default_test --test_output=errors '--test_arg=-testify.m=Test(Ingest|QueueStatus|IssueTracking_DLQ|List|Ping)'.TestIssueTracking_FinalizesAfterAnalysisalso times out on unchanged main at 0edea98 with a 120-second Bazel limit.Revert Plan
Revert this PR to restore the previous constructor and startup registration together.
Issue
No linked issue; this fixes constructor composition and first-ingest initialization.