Skip to content

feat(orchestrator): Wire the Tango conflict analyzer into the reference server - #913

Merged
manjari25 merged 2 commits into
manjari/tango-clientfrom
manjari/tango-wiring
Oct 27, 2026
Merged

manjari25 merged 2 commits into
manjari/tango-clientfrom
manjari/tango-wiring

Conversation

@manjari25

@manjari25 manjari25 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Why?

The tango analyzer and its client adapter have no way to run in the reference orchestrator. This wires them in so a queue can select analyzer: tango.

What?

  • tangoclient: Dial opens a lazy gRPC connection to Tango. Connection.ChangedTargetsClient builds the adapter for a remote and a strategy (unset, shell or native, required).
  • Config: a top-level tango block (address, signatureCacheBytes) and a per-queue analyzer.tango block (remote, strategy). Neither strategy nor the top-level settings have defaults.
  • Validation: the address and a positive cache size are required whenever any queue uses tango, and every tango queue needs a strategy. The builder rejects a tango queue that doesn't use the git change provider.
  • Builder: one shared signature cache, a per-queue MySQL signature store, and the base revision read from the queue's own clone. Base-revision fetches take the same gitrepo.Repo lock as the git change provider.
  • README: the new config keys and two limits. Tango needs a git-provider queue until the GitHub base revision exists, and native needs github:// URIs that the git provider doesn't emit.

Test Plan

  • bazel test //service/submitqueue/orchestrator/server/... //submitqueue/extension/conflict/tango/... covers the config validation, the builder and the adapter.
  • CI.

Issue

@manjari25
manjari25 marked this pull request as ready for review October 22, 2026 05:48
@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners October 22, 2026 05:48
@manjari25
manjari25 added this pull request to stack #912 October 22, 2026 05:48
Comment thread submitqueue/extension/conflict/tango/tangoclient/connection.go
Comment thread service/submitqueue/orchestrator/server/config.go Outdated
Comment thread service/submitqueue/orchestrator/server/config.go Outdated
Comment thread submitqueue/extension/conflict/tango/tangoclient/connection.go Outdated
@manjari25
manjari25 added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 27, 2026
@manjari25
manjari25 added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 27, 2026
@manjari25
manjari25 added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 27, 2026
@manjari25
manjari25 force-pushed the manjari/tango-wiring branch from 446dcb3 to b9ff792 Compare October 27, 2026 19:46
@manjari25
manjari25 added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 1654524 Oct 27, 2026
19 checks passed
@manjari25
manjari25 deleted the manjari/tango-wiring branch October 27, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants