Repository navigation
Conversation
This was referenced Oct 14, 2026
mnoah1
added this pull request to stack #858
October 14, 2026 15:45
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
October 14, 2026 17:57
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 14, 2026 17:57
| // Required stable repo-and-ref queue name. | ||
| string queue = 1; | ||
| // Optional immutable commit URI. Empty selects the latest materialized state. | ||
| string change_uri = 2; |
Collaborator
There was a problem hiding this comment.
this can be any commit and not just the ones we processed?
behinddwalls
left a comment
behinddwalls
left a comment
Collaborator
There was a problem hiding this comment.
Proto and RFC look good: the wire change is additive, the zero value is a sentinel, and the RFC matches the proto fields. I have one suggestion about a test.
Summary: Queue enablement needs a dedicated lookup: validation results and the current queue row do not identify the state covering an arbitrary commit. Define GetQueueStatus with an optional change URI and one selected state, commit generated bindings, and document inclusive boundaries, intermediate commits and error semantics in the indexed RFC. The RPC remains unimplemented until the final layer. Part 1 of 4: API and RFC → storage → transitions and materialization → lookup. Test Plan: Build the published bindings and run the Stovepipe server tests. The final stack also passes all 27 Stovepipe unit, MySQL integration, service integration and end-to-end targets.
mnoah1
force-pushed
the
mnoah1/stovepipe-queue-state-api
branch
from
October 14, 2026 22:35
95adb11 to
8c55c7e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Queue enablement needs a dedicated lookup: validation results and the current queue row do not identify the state covering an arbitrary commit.
What?
Define GetQueueStatus with an optional change URI and an
enablementfield of typeQueueEnablementStatus, commit generated bindings, and document inclusive boundaries, intermediate commits and error semantics in the indexed RFC. The RPC remains unimplemented until the final layer.Test Plan
Build the published bindings and run the Stovepipe server tests. The final stack also passes all 27 Stovepipe unit, MySQL integration, service integration and end-to-end targets.
Revert Plan
Revert this layer together with any dependent layers in the stack.
Stack
Review in this order; each PR targets the preceding branch.