Repository navigation
Conversation
manjari25
marked this pull request as draft
October 13, 2026 19:47
manjari25
force-pushed
the
manjari/tango-dictionary-store-mysql
branch
from
October 14, 2026 02:11
6146b94 to
9dc6b48
Compare
manjari25
marked this pull request as ready for review
October 14, 2026 18:10
manjari25
added this pull request to stack #872
October 14, 2026 21:02
manjari25
force-pushed
the
manjari/tango-dictionary-store-mysql
branch
from
October 15, 2026 22:05
9dc6b48 to
29d5822
Compare
behinddwalls
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Signatures hold 64-bit hashes, not labels. To explain or debug a conflict, someone needs to map an ID back to the target label it stands for. This PR implements the
DictionaryStorecontract from the first PR in the stack on MySQL, as part of the package owned by the tango conflict extension.What?
Everything is added under
submitqueue/extension/conflict/tango/mysql:target_dictionarytable:(queue, id), with no secondary index.TEXTvalue column.DictionaryStore:Createreturnsstorage.ErrAlreadyExistsif the ID is already recorded, even with a different label, so the first label on a hash collision stays.Getreports an unrecorded ID asfound=false, not as an error.Storageaggregate. Nothing constructs it yet.Test Plan
./tool/bazel test //submitqueue/extension/conflict/tango/mysql:go_default_test./tool/bazel test //test/integration/submitqueue/extension/conflict/tango/mysql/... --test_output=streamedmake check-gazellemake check-mocksmake lintCI
Issue