Repository navigation
Conversation
manjari25
marked this pull request as draft
October 13, 2026 19:47
manjari25
force-pushed
the
manjari/tango-signature-store-mysql
branch
from
October 14, 2026 02:08
06ebfe1 to
91a0be2
Compare
manjari25
marked this pull request as ready for review
October 14, 2026 18:09
manjari25
added this pull request to stack #872
October 14, 2026 21:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Signatures are expensive to recompute, so the analyzer needs a durable source of truth keyed by batch. This PR implements the
TargetSignatureStorecontract from the previous PR on MySQL and exposes it through the orchestrator's storage aggregate.What?
target_signaturetable:(queue, batch_id), with no secondary index.targetsis aLONGBLOB, because the largest signatures can be large.TargetSignatureStore:ErrAlreadyExists.Getreports a missing batch asfound=false, not as an error.entity.TargetSignature.GetTargetSignatureStore()to the orchestratorStorageaggregate only, so the gateway cannot reach it. The mock is regenerated.doc/rfc/service-scoped-extensions.mdfor the new accessor and table.Test Plan
./tool/bazel test //submitqueue/orchestrator/extension/storage/mysql:go_default_test./tool/bazel test //test/integration/submitqueue/extension/storage/mysql/... --test_output=streamedmake check-gazellemake check-mocksmake lintCI
Issue