Skip to content

refactor(platform): Move GitRuntime into gitworkspace/local as Runtime - #769

Open
manjari25 wants to merge 1 commit into
mainfrom
manjari/gitruntime-platform
Open

manjari25 wants to merge 1 commit into
mainfrom
manjari/gitruntime-platform

Conversation

@manjari25

@manjari25 manjari25 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Why?

The pinned git runtime (executable, helper paths, scrubbed environment) is how the local workspace backend runs git, so it belongs in that backend rather than in the merger. The merger and the runway server wiring import it from there.

What?

  • Move the pinned git runtime (GitRuntime) from the merger into platform/extension/gitworkspace/local as Runtime, with Validate() and Command().
  • Switch the merger and the runway server wiring to gitlocal.Runtime.
  • Move the runtime tests next to the code, and add one for HOME isolation.
  • Validate now checks fields in a fixed order, so its error is deterministic. This is the only logic change.

Test Plan

  • bazel test //platform/extension/gitworkspace/... //runway/extension/merger/... //service/runway/...
  • make check-gazelle, make check-tidy and make lint pass
  • CI

Issues

@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners October 2, 2026 19:54
Comment thread platform/git/exec/runtime.go Outdated
@manjari25
manjari25 force-pushed the manjari/gitruntime-platform branch from 13aa5fa to 7602fd8 Compare October 14, 2026 17:53
@manjari25 manjari25 changed the title refactor(platform): Move GitRuntime into platform/git/exec as Runtime refactor(platform): Move GitRuntime into gitworkspace/local as Runtime Oct 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants