Update checkbox-v2.ts - #5424
Open
MaddipatlaChetan24 wants to merge 1 commit into
Open
MaddipatlaChetan24 wants to merge 1 commit into
MaddipatlaChetan24 wants to merge 1 commit into
Conversation
MaddipatlaChetan24
requested review from
DianaSuvorova,
dyesin,
hualf1995 and
lijim
as code owners
September 20, 2026 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
Description
CheckboxConfig's pickedchangeHandlerslist includedonMouseDownand the complete
onMouseEnter/onMouseLeavepair, but omittedonMouseUp. Confirmed against baseui's own API docs thatCheckboxsupports
onMouseUpas a first-class prop alongsideonMouseDown,onMouseEnter,onMouseLeave,onFocus, andonBlur— so this wasa real supported handler missing from the playground config, not a
deliberate omission of an unsupported prop.
Fix: added
"onMouseUp"to the picked list. AssumeschangeHandlersin
./common/commonalready defines anonMouseUpentry parallel toits existing
onMouseDownentry — please confirm that file has itbefore merging, since I don't have its contents.
Scope
Patch: Bug Fix