test(sensor): isolate redirected APPDATA test - #111
Merged
Conversation
pengyuzhang
reviewed
Aug 26, 2026
weibit
commented
Aug 26, 2026
weibit
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. You are right, the previous version bypassed the production APPDATA-to-DB_PATHS link. I updated the test to set APPDATA, reload cursor_parser, retain the Windows candidate generated by the reloaded CursorParser.DB_PATHS, and replace only the macOS/Linux candidates with nonexistent paths. The module is restored in a finally block. The full 123-test Sensor suite passed.
pengyuzhang
approved these changes
Aug 26, 2026
pengyuzhang
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the redirected APPDATA test isolation change. No blocking findings. Verified the exact PR head: 123 Sensor tests pass, and the changed test file passes Ruff.
Contributor
Author
|
My apologies. I accidentally clicked “Close pull request.” Reopening it for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue:
N/A
What changed?
Updated the redirected
%APPDATA%Cursor parser test to use pytest'smonkeypatchfixture and deterministic database candidates.Why?
The test previously searched the normal macOS Cursor database before the temporary Windows database. On macOS systems with Cursor installed, the real database was selected and the test failed.
The revised test is isolated from applications and log files installed on the host machine.
How did you test it?
uv run pytest -qResult:
123 passeduv run ruff check adr_sensor testsPotential risks
Low. This changes test setup only and does not modify production parser behavior.