Repository navigation
Feat/gauge drawing improvements - #225
Merged
Merged
Conversation
- Scale labels on nice steps (1/2/2.5/4/5 x 10^n) with the range extended to the nearest step; progress, labels and ticks share GaugeScale. - Red marks only the PID's alert ranges instead of every dial's end. - Side labels pulled inward; min/avg/max centred with captions and fitted; long values shrink to the dial. - Phone cards share the free height when the grid does not scroll. - Fix: out-of-range values drew the arc past the dial; angle no longer truncated; scale bitmap cache keyed by range and alerts, old bitmap recycled. - Cache the container gradient and resolved colours per frame.
- Scale bitmap was cached without numbers while the value was still null; numbers are now skipped only for non-numeric values and are part of the cache key. - Draw numbers after the ticks (red glow covered the end labels) and keep them at their radius unless they would reach the ticks. - Limit the min/avg/max row to the space beside the end label when the dial ends below its centre.
- Phone dials are centred on what the arc draws, not on their square: a 200-degree dial left the bottom third of every card empty. - displayUnits() adds the degree sign to bare C/F units on every surface-rendered screen; PID data, exports and logs keep "C".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.