Repository navigation
fix(performance,trip-info): list bottom-row dialogs in the default order - #224
Merged
Merged
Conversation
fix(performance,trip-info): list bottom-row dialogs in the default order Opening the gauge / bottom-row dialog stores the checked rows' listed order as the drag order, which beats the default order in PidOrder. The rows came from a Set, so merely opening the dialog fixed a random gauge order. List both dialogs in the profile / default bottom order, and move PidOrder to :datalogger so the dialogs and the renderers share one comparator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(performance,trip-info): list bottom-row dialogs in the default order
Opening the gauge / bottom-row dialog stores the checked rows' listed order as the drag order, which beats the default order in PidOrder. The rows came from a Set, so merely opening the dialog fixed a random gauge order.
List both dialogs in the profile / default bottom order, and move PidOrder to :datalogger so the dialogs and the renderers share one comparator.