Repository navigation
feat(performance): allow any PID on the Performance screen - #222
Merged
Merged
Conversation
tzebrowski
commented
Oct 7, 2026
tzebrowski
commented
Owner
- PID dialog offers the full registry; profile PIDs and current selection stay listed unfiltered
- Selected PIDs outside the profile lists are drawn in the grid after the profile's top PIDs, in dialog order
- New "Gauge PIDs" setting (max 5); unset keeps the profile's bottom list, empty means no gauges
- Grid shrinks text and adds columns above 15 items within the same 3-row height, "+N" past 24
- TripInfoMetrics.grid() parameterised by base columns/rows and shared with Performance
- Plain JUnit PerformanceMetricsTest; PerformanceQueryStrategyTest covers the gauge dialog selection
- Spec: doc/specs/performance-dynamic-pids.md
- PID dialog offers the full registry; profile PIDs and current selection stay listed unfiltered - Selected PIDs outside the profile lists are drawn in the grid after the profile's top PIDs, in dialog order - New "Gauge PIDs" setting (max 5); unset keeps the profile's bottom list, empty means no gauges - Grid shrinks text and adds columns above 15 items within the same 3-row height, "+N" past 24 - TripInfoMetrics.grid() parameterised by base columns/rows and shared with Performance - Plain JUnit PerformanceMetricsTest; PerformanceQueryStrategyTest covers the gauge dialog selection - Spec: doc/specs/performance-dynamic-pids.md
Document in the spec and CLAUDE.md that the phone Performance screen follows the AA gauge selection and order, and that gauges past MAX_GAUGES fall back into the grid. Rename a test that asserts order, not layout.
…ix stats width - Gauge dialog shows a toast when more than 5 gauges are checked (extras still fall back into the grid). - Saving the Performance selection drops deselected PIDs from a stored gauge selection, so a reselected PID no longer comes back as a gauge. - Performance passes its own column width to TripInfoDrawer.drawMetric; min/max stats were clamped to Trip Info's 6-column width. - Move the gauge cap to PERFORMANCE_MAX_GAUGES in :datalogger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.